Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobQueue reimplemented in Python #6579

Closed
wants to merge 65 commits into from
Closed

JobQueue reimplemented in Python #6579

wants to merge 65 commits into from

Conversation

berland
Copy link
Contributor

@berland berland commented Nov 16, 2023

Issue
Resolves #6270

Approach
Total rewrite.

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

There is no need to test get_option in the driver,
and config_dict_generator is testing the slurm memory options
We don't need testing of get_options, and that
we get an LSF driver when we ask for it
@berland
Copy link
Contributor Author

berland commented Dec 13, 2023

This has been abandoned in favour of #6749 and subsequent PR's.

@berland berland closed this Dec 13, 2023
@berland berland deleted the python_jobqueue branch April 10, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Refactor queue drivers
7 participants