-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JobQueue reimplemented in Python #6579
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be flakyness in python pickout up stdout from qsub
Removed snapshot as it is no longer used Removed iens in one constructor as it is no longer part of the class
Updated some type hints Formatted a few lines Added some asserts and if guards
Written assuming there will be a global option to set SUBMIT_SLEEP, but will currently pick from the selected queue system.
Also added return value to _add_realization as that is expected by other functions
Poking an internal variable in queue, _queue_stopped. This should perhaps be an official way in order to stop the queue from a sync context
+ mypy ignore in _legacy.py
Ensure storage state is set correctly when runs fail. Adjust error string building Passes test_tracking_integration
There is no need to test get_option in the driver, and config_dict_generator is testing the slurm memory options
We don't need testing of get_options, and that we get an LSF driver when we ask for it
This has been abandoned in favour of #6749 and subsequent PR's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #6270
Approach
Total rewrite.
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist